Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-1954 Fix Data API ReadtheDocs #77

Merged
merged 5 commits into from
Dec 14, 2022

Conversation

ddl-gabrielhaim
Copy link
Collaborator

@ddl-gabrielhaim ddl-gabrielhaim commented Dec 13, 2022

Description

ReadtheDocs python reference documentation is broken

Related Issue

https://dominodatalab.atlassian.net/browse/DOCS-1954

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@ddl-gabrielhaim ddl-gabrielhaim requested review from ddl-lgaddie and a team December 13, 2022 22:10
@ddl-gabrielhaim ddl-gabrielhaim changed the title Fix Data API ReadtheDocs DOCS-1954 Fix Data API ReadtheDocs Dec 13, 2022
@github-actions
Copy link

github-actions bot commented Dec 13, 2022

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.9.15-final-0 -----------

Name Stmts Miss Cover
domino_data/init.py 7 2 71%
domino_data/_feature_store/init.py 0 0 100%
domino_data/_feature_store/client.py 41 3 93%
domino_data/_feature_store/exceptions.py 9 0 100%
domino_data/_feature_store/git.py 43 1 98%
domino_data/_feature_store/run.py 16 16 0%
domino_data/_feature_store/sync.py 96 9 91%
domino_data/auth.py 84 12 86%
domino_data/configuration_gen.py 158 0 100%
domino_data/data_sources.py 266 15 94%
domino_data/logging.py 11 0 100%
domino_data/training_sets/init.py 0 0 100%
domino_data/training_sets/client.py 126 10 92%
domino_data/training_sets/model.py 42 0 100%
TOTAL 899 68 92%

~ 54 passed in 21.23s ~

@@ -21,4 +22,4 @@ build:
sphinx:
builder: html
configuration: docs/source/conf.py
fail_on_warning: false
fail_on_warning: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: The comment on Line 21 doesn't match the configuration here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ddl-joyce-zhao !

@ddl-gabrielhaim ddl-gabrielhaim merged commit 362a291 into main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants