Update feature views with commit hash included #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddl-catherinetu
commented
Dec 8, 2022
| colorama==0.4.6 ; python_version >= "3.8" and python_version < "4.0" and sys_platform == "win32" | ||
| h11==0.14.0 ; python_version >= "3.8" and python_version < "4.0" | ||
| httpcore==0.16.1 ; python_version >= "3.8" and python_version < "4.0" | ||
| httpcore==0.16.2 ; python_version >= "3.8" and python_version < "4.0" | ||
| httpx==0.23.1 ; python_version >= "3.8" and python_version < "4.0" |
There was a problem hiding this comment.
poetry.lock and requirements.txt is changed after I ran make install, I think that should be okay? @ddl-gabrielhaim
ddl-catherinetu
force-pushed
the
ddl-ctu.DOM-42358.update-commit-hash-featureviews
branch
from
112c497 to
f5257b0
Compare
ddl-catherinetu
force-pushed
the
ddl-ctu.DOM-42358.update-commit-hash-featureviews
branch
from
f5257b0 to
4c72771
Compare
✅ Result of Pytest Coverage---------- coverage: platform linux, python 3.10.8-final-0 -----------
~ 54 passed in 23.13s ~ |
Comment on lines
70
to
+71
| Repo.__new__ = MagicMock() | ||
| Repo.__new__.return_value = repo_mock |
There was a problem hiding this comment.
Nit: this two lines can be combined together: Repo.__new__ = MagicMock(return_value=repo_mock)
ddl-joyce-zhao
approved these changes
Dec 8, 2022
|
BTW, the safety check failed. Might need to bump up some libraries' version. |
|
It was closed by mistake. Reopen it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upsert feature views has a commit hash that needs to be passed to the API
Related Issue
https://dominodatalab.atlassian.net/browse/DOM-42358
Type of Change