Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3/ObjectStore metrics #6

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Add S3/ObjectStore metrics #6

merged 2 commits into from
Nov 4, 2021

Conversation

ddl-gabrielhaim
Copy link
Collaborator

@ddl-gabrielhaim ddl-gabrielhaim commented Nov 4, 2021

Description

ObjectStore operations can only log content processed from the SDK

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@github-actions
Copy link

github-actions bot commented Nov 4, 2021

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.8.12-final-0 -----------

Name Stmts Miss Cover
domino_data/init.py 6 0 100%
domino_data/auth.py 56 3 95%
domino_data/data_sources.py 260 21 92%
domino_data/logging.py 8 0 100%
domino_data/training_sets/init.py 0 0 100%
domino_data/training_sets/client.py 125 11 91%
domino_data/training_sets/model.py 42 0 100%
TOTAL 497 35 93%

~ 35 passed in 4.56s ~

@ddl-gabrielhaim ddl-gabrielhaim merged commit 1fca1d3 into main Nov 4, 2021
@ddl-gabrielhaim ddl-gabrielhaim deleted the gh.add.metrics branch November 4, 2021 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants