Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions to simplify Pinecone 3x client API parameters with Domino #139

Merged
merged 6 commits into from
Mar 4, 2024

Conversation

ddl-joyce-zhao
Copy link
Contributor

@ddl-joyce-zhao ddl-joyce-zhao commented Mar 4, 2024

Description

Added two functions wrapping the parameters to initialize the Pinecone client and target the index for Pinecone 3.x python client with Domino data source

Related Issue

https://dominodatalab.atlassian.net/browse/DOM-54988

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

Copy link

github-actions bot commented Mar 4, 2024

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.8.18-final-0 -----------

Name Stmts Miss Cover
domino_data/init.py 7 2 71%
domino_data/_feature_store/init.py 0 0 100%
domino_data/_feature_store/client.py 41 3 93%
domino_data/_feature_store/exceptions.py 9 0 100%
domino_data/_feature_store/git.py 43 1 98%
domino_data/_feature_store/logging.py 7 0 100%
domino_data/_feature_store/run.py 16 16 0%
domino_data/_feature_store/sync.py 98 9 91%
domino_data/auth.py 90 13 86%
domino_data/configuration_gen.py 232 0 100%
domino_data/data_sources.py 290 24 92%
domino_data/logging.py 10 0 100%
domino_data/meta.py 22 0 100%
domino_data/training_sets/init.py 0 0 100%
domino_data/training_sets/client.py 126 10 92%
domino_data/training_sets/model.py 42 0 100%
domino_data/transfer.py 37 0 100%
domino_data/vectordb.py 23 4 83%
TOTAL 1093 82 92%

~ 67 passed in 11.49s ~

@ddl-joyce-zhao ddl-joyce-zhao marked this pull request as ready for review March 4, 2024 19:02
@ddl-joyce-zhao ddl-joyce-zhao requested a review from a team March 4, 2024 19:03
@ddl-joyce-zhao ddl-joyce-zhao merged commit 86de166 into main Mar 4, 2024
7 checks passed
@ddl-joyce-zhao ddl-joyce-zhao deleted the ddl-joyce-zhao.DOM-54988.pinecone3x branch March 4, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants