Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOM-49875] SDK Code Generation for Databricks based on Services Module #118

Merged
merged 8 commits into from
Sep 15, 2023

Conversation

ddl-eric-jin
Copy link
Collaborator

@ddl-eric-jin ddl-eric-jin commented Sep 8, 2023

Description

Code generation and SDK services module update to support Databricks as a datasource.

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@ddl-eric-jin ddl-eric-jin requested a review from a team September 8, 2023 23:06
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.8.18-final-0 -----------

Name Stmts Miss Cover
domino_data/init.py 7 2 71%
domino_data/_feature_store/init.py 0 0 100%
domino_data/_feature_store/client.py 41 3 93%
domino_data/_feature_store/exceptions.py 9 0 100%
domino_data/_feature_store/git.py 43 1 98%
domino_data/_feature_store/logging.py 7 0 100%
domino_data/_feature_store/run.py 16 16 0%
domino_data/_feature_store/sync.py 98 9 91%
domino_data/auth.py 90 13 86%
domino_data/configuration_gen.py 227 0 100%
domino_data/data_sources.py 290 24 92%
domino_data/logging.py 10 0 100%
domino_data/meta.py 22 0 100%
domino_data/training_sets/init.py 0 0 100%
domino_data/training_sets/client.py 126 10 92%
domino_data/training_sets/model.py 42 0 100%
domino_data/transfer.py 37 0 100%
TOTAL 1065 78 93%
======================= 64 passed, 2

@ddl-eric-jin ddl-eric-jin self-assigned this Sep 8, 2023
@ddl-eric-jin ddl-eric-jin marked this pull request as ready for review September 11, 2023 22:17
@ddl-eric-jin ddl-eric-jin requested a review from a team September 13, 2023 18:33
@ddl-eric-jin ddl-eric-jin merged commit 8b3b178 into main Sep 15, 2023
@ddl-eric-jin ddl-eric-jin deleted the ddl-eric-jin.DOM-49875.SDK-code-gen branch September 15, 2023 20:02
@ddl-eric-jin ddl-eric-jin restored the ddl-eric-jin.DOM-49875.SDK-code-gen branch September 15, 2023 20:02
@ddl-eric-jin ddl-eric-jin deleted the ddl-eric-jin.DOM-49875.SDK-code-gen branch September 15, 2023 20:02
@ddl-eric-jin ddl-eric-jin restored the ddl-eric-jin.DOM-49875.SDK-code-gen branch September 15, 2023 20:02
@ddl-eric-jin ddl-eric-jin deleted the ddl-eric-jin.DOM-49875.SDK-code-gen branch September 15, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants