Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Source of Truth for Data-Services to Include Azure Blob Storage #110

Merged

Conversation

ddl-eric-jin
Copy link
Collaborator

@ddl-eric-jin ddl-eric-jin commented Aug 25, 2023

Description

Update submodule "services" to include Azure Blob Storage Config.

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@ddl-eric-jin ddl-eric-jin requested a review from a team August 25, 2023 21:44
@ddl-eric-jin ddl-eric-jin self-assigned this Aug 25, 2023
@ddl-eric-jin ddl-eric-jin marked this pull request as ready for review August 25, 2023 21:44
@github-actions
Copy link

github-actions bot commented Aug 25, 2023

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.8.17-final-0 -----------

Name Stmts Miss Cover
domino_data/init.py 7 2 71%
domino_data/_feature_store/init.py 0 0 100%
domino_data/_feature_store/client.py 41 3 93%
domino_data/_feature_store/exceptions.py 9 0 100%
domino_data/_feature_store/git.py 43 1 98%
domino_data/_feature_store/logging.py 7 0 100%
domino_data/_feature_store/run.py 16 16 0%
domino_data/_feature_store/sync.py 98 9 91%
domino_data/auth.py 84 12 86%
domino_data/configuration_gen.py 217 0 100%
domino_data/data_sources.py 277 24 91%
domino_data/logging.py 10 0 100%
domino_data/training_sets/init.py 0 0 100%
domino_data/training_sets/client.py 126 10 92%
domino_data/training_sets/model.py 42 0 100%
domino_data/transfer.py 37 0 100%
TOTAL 1014 77 92%
======================= 62 passed, 2

@ddl-joyce-zhao
Copy link
Contributor

I think this also needs to be updated with data source proxy client re-generated too.

https://github.com/dominodatalab/domino-data/blob/main/openapi/datasource.yaml#L220

The command to update the client can be found in the make file.

@ddl-eric-jin
Copy link
Collaborator Author

I think this also needs to be updated with data source proxy client re-generated too.

https://github.com/dominodatalab/domino-data/blob/main/openapi/datasource.yaml#L220

The command to update the client can be found in the make file.

Thank you for the comment. I just updated it with the code gen to include the Azure Blob configuration. Thanks!

@ddl-eric-jin ddl-eric-jin merged commit b3eb2b0 into main Aug 28, 2023
@ddl-eric-jin ddl-eric-jin deleted the ddl-eric-jin.DOM-48759.update-data-submodule-azure-blob branch August 28, 2023 17:49
@ddl-eric-jin ddl-eric-jin restored the ddl-eric-jin.DOM-48759.update-data-submodule-azure-blob branch August 28, 2023 17:49
@ddl-eric-jin ddl-eric-jin deleted the ddl-eric-jin.DOM-48759.update-data-submodule-azure-blob branch August 28, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants