Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error handling #100

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

ddl-joyce-zhao
Copy link
Contributor

@ddl-joyce-zhao ddl-joyce-zhao commented Jul 26, 2023

Description

Improved error handling while getting data sources.

Related Issue

https://dominodatalab.atlassian.net/browse/DOM-48640

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@github-actions
Copy link

github-actions bot commented Jul 26, 2023

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.8.17-final-0 -----------

Name Stmts Miss Cover
domino_data/init.py 7 2 71%
domino_data/_feature_store/init.py 0 0 100%
domino_data/_feature_store/client.py 41 3 93%
domino_data/_feature_store/exceptions.py 9 0 100%
domino_data/_feature_store/git.py 43 1 98%
domino_data/_feature_store/logging.py 7 0 100%
domino_data/_feature_store/run.py 16 16 0%
domino_data/_feature_store/sync.py 98 9 91%
domino_data/auth.py 84 12 86%
domino_data/configuration_gen.py 213 0 100%
domino_data/data_sources.py 277 24 91%
domino_data/logging.py 10 0 100%
domino_data/training_sets/init.py 0 0 100%
domino_data/training_sets/client.py 126 10 92%
domino_data/training_sets/model.py 42 0 100%
domino_data/transfer.py 37 0 100%
TOTAL 1010 77 92%
======================= 61 passed, 2

@ddl-joyce-zhao ddl-joyce-zhao marked this pull request as ready for review July 26, 2023 15:43
@ddl-joyce-zhao ddl-joyce-zhao requested a review from a team July 26, 2023 15:43
Copy link
Contributor

@ddl-aj-rossman ddl-aj-rossman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ddl-joyce-zhao ddl-joyce-zhao merged commit d8157e6 into main Jul 26, 2023
@ddl-joyce-zhao ddl-joyce-zhao deleted the ddl-joyce-zhao.DOM-48640.error-handling branch July 26, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants