Merge pull request #80 from FriedlandAaron/feat/raw-mode-flag #183
GitHub Actions / clippy
succeeded
Jun 13, 2024 in 0s
clippy
4 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 4 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.79.0 (129f3b996 2024-06-10)
- cargo 1.79.0 (ffa9cf99a 2024-06-03)
- clippy 0.1.79 (129f3b9 2024-06-10)
Annotations
Check warning on line 217 in src/args.rs
github-actions / clippy
unnecessary use of `get(&flag_name).is_some()`
warning: unnecessary use of `get(&flag_name).is_some()`
--> src/args.rs:217:23
|
217 | if options_lookup.get(&flag_name).is_some() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(&flag_name)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
= note: `#[warn(clippy::unnecessary_get_then_check)]` on by default
Check warning on line 202 in src/args.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> src/args.rs:202:2
|
202 | options.text = my_args[1].clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `options.text.clone_from(&my_args[1])`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
Check warning on line 217 in src/args.rs
github-actions / clippy
unnecessary use of `get(&flag_name).is_some()`
warning: unnecessary use of `get(&flag_name).is_some()`
--> src/args.rs:217:23
|
217 | if options_lookup.get(&flag_name).is_some() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(&flag_name)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
= note: `#[warn(clippy::unnecessary_get_then_check)]` on by default
Check warning on line 202 in src/args.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> src/args.rs:202:2
|
202 | options.text = my_args[1].clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `options.text.clone_from(&my_args[1])`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
Loading