New style check "mixing pointer and value receivers"

[nikolaydubina]

what?

similar to https://github.com/nikolaydubina/smrcptr

why?

Go has rules on how it can automatically select value and method receivers, which is complex and can lead to bugs.

Official Go guideline recommends:

Don't mix receiver types. Choose either pointers or struct types for all available methods.

Google Go style guide: https://google.github.io/styleguide/go/decisions#receiver-type

approach

Probably similar to https://github.com/dominikh/go-tools/blob/master/stylecheck/lint.go#L295

I can implement in free time too.

🙇🏻‍♂️

[dominikh]

This is out of scope for Staticcheck on account of false positives; I don't think the guideline is universally true. It would certainly flag some exported APIs in the Go standard library.

[ainar-g]

This wouldn't be as straightforward because some interfaces de facto require a value or a pointer receiver. Most notably, the (un)marshaling ones. See #911 and the issues mentioned there.

[nikolaydubina]

Sure, I see where you are coming from. I run this tool on large enterprise projects, and there was surprisingly rare instances of false positives. UnmarshalJSON and alike are apparently not as prevalent. Well, thanks anyways! Until next time then! 👋🏻

…

On Thu, 1 Dec 2022 at 23:33, Ainar Garipov ***@***.***> wrote: This wouldn't be as straightforward because some interfaces *de facto* require a value or a pointer receiver. Most notably, the (un)marshaling ones. See #911 <#911> and the issues mentioned there. — Reply to this email directly, view it on GitHub <#1337 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAWMCRKZKLYRS4YH4ZHXVR3WLDANZANCNFSM6AAAAAASPYPJGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>