stylecheck: avoid flagging error strings that begin with a function call

Closes gh-452 (cherry picked from commit d9d28f5)
dominikh · Oct 10, 2020 · a4a005d · a4a005d
1 parent 33cf363
commit a4a005d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/stylecheck/lint.go b/stylecheck/lint.go
@@ -410,6 +410,10 @@ func CheckErrorStrings(pass *analysis.Pass) (interface{}, error) {
 					}
 				}
 
+				if strings.ContainsRune(word, '(') {
+					// Might be a function call
+					continue instrLoop
+				}
 				word = strings.TrimRightFunc(word, func(r rune) bool { return unicode.IsPunct(r) })
 				if objNames[fn.Package()][word] {
 					// Word is probably the name of a function or type in this package

diff --git a/stylecheck/testdata/src/CheckErrorStrings/CheckErrorStrings.go b/stylecheck/testdata/src/CheckErrorStrings/CheckErrorStrings.go
@@ -11,6 +11,9 @@ func fn() {
 	errors.New("SomeFunc is okay")
 	errors.New("URL is okay, but the period is not.") // want `error strings should not end with punctuation or a newline`
 	errors.New("T must not be nil")
+	errors.New("Foo() failed")
+	errors.New("Foo(bar) failed")
+	errors.New("Foo(bar, baz) failed")
 }
 
 func Write() {