Add go-{browse-{freesymbols,doc,assembly},rename} #439
Conversation
go-mode.el
Outdated
| (interactive) | ||
| (go-mode--code-action "source.freesymbols")) | ||
|
|
||
| (defun go-doc () |
There was a problem hiding this comment.
Something like go-browse-doc might fit better, both to distinguish it from the existing godoc and to make it more apparent that it'll open the documentation in a browser. WDYT?
There was a problem hiding this comment.
Something like go-browse-doc might fit better, both to distinguish it from the existing godoc and to make it more apparent that it'll open the documentation in a browser. WDYT?
My preference was to omit it for the sake of brevity, but I confess I wasn't aware of the existing godoc function, so I now see the potential for confusion. Done.
adonovan
changed the title
|
(Don't merge this yet: I've come around to using the |
These four helper functions provide convenient ways to access gopls server functionality without the user needing to worry about how their LSP client does things. They should work for eglot and lsp-mode (though I haven't tested the latter). Updates dominikh/go-mode.el/dominikh#436
adonovan
changed the title
Done. Please take another look. |
|
We're planning to release gopls/v0.16 today, and its release notes will mention these new functions; it would be great if we could merge this PR soon. Do let me know if there's anything you need from me. |
|
@adonovan Sorry for the delay. It's been merged to master now. Do you need a tagged release, or are people used to installing from master? |
No need to tag release; I have learned that Emacs users don't expect things to be easy. ;-) Thanks. |
These four helper functions provide convenient ways to access gopls server functionality without the user needing to worry about how their LSP client does things. They should work for eglot and lsp-mode (though I haven't tested the latter).
Updates dominikh/go-mode.el/#436