Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for ts 5 #80

Merged
merged 6 commits into from
Mar 2, 2023
Merged

feat: add support for ts 5 #80

merged 6 commits into from
Mar 2, 2023

Conversation

dominikg
Copy link
Owner

@dominikg dominikg commented Feb 23, 2023 •
edited
Loading

Additions:

  • resolve extends array
  • parse moduleResolution: bundler correctly

@dominikg dominikg marked this pull request as ready for review March 2, 2023 14:28
@dominikg dominikg changed the title feat: add support for ts 5 beta and implement parsing extends array feat: add support for ts 5 Mar 2, 2023
@dominikg
Copy link
Owner Author

dominikg commented Mar 2, 2023

  • ts5 no longer allows extends: "" so that had to be removed from test fixtures.
  • dependency updates were required to get tsup+esbuild to work together with ts5.

the Implementation with reversing the extends array for resolving is based on the description in

https://devblogs.microsoft.com/typescript/announcing-typescript-5-0-beta/#supporting-multiple-configuration-files-in-extends

pr that implements extends array in TS itself: microsoft/TypeScript#50403

@dominikg dominikg merged commit 1026f90 into main Mar 2, 2023
@dominikg dominikg deleted the feat/extends-array branch March 2, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dominikg