Feature- Filter out missing elements #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominictwlee
requested changes
Jun 22, 2020
There was a problem hiding this comment.
lgtm, but potentially breaking changes for MySenseDashboard regarding the change in dataset.position mechanism so please mark commit with BREAKING CHANGE: blah blah in body so that CI will know to release a major version.
Also either resolve all warnings/explicitly mark eslint-disable followed by comment on why it needs to be disabled.
BREAKING CHANGE: update API to not use data attributes
DarbyBrown
force-pushed
the
feature/filter-out-missing-elements
branch
from
3ad32d3
to
97a5d34
Compare
dominictwlee
approved these changes
Jun 22, 2020
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
dominictwlee
added a commit
that referenced
this pull request
Jun 23, 2020
This reverts commit 5954c78.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Want to be able to disable components from the tour without having to change the config.
If a DOM node is missing from the order of tour positions we will remove the corresponding messages and tool tips.