Skip to content
This repository has been archived by the owner on Mar 23, 2019. It is now read-only.

Fix main entry in package.json #8

Closed
wants to merge 1 commit into from

Conversation

BridgeAR
Copy link

There is no assert.js file. The module resolve algorithm is very forgiving at the moment and also tries to resolve the index.js file in a directory even though the main entry is invalid. That's why this currently works.

This could likely change for Node.js v12 (nodejs/node#26823) and it would be great to fix this.

@dominictarr
Copy link
Owner

I can't publish this change, I no longer have publish access to that module.

@BridgeAR
Copy link
Author

@dominictarr thanks, I did not notice that before. I also saw that you archived JSONStream and it seems like you do not have publishing access to that module either. Since the links in the published modules still reference to your github pages: whom should I reach out to, to create a PR for JSONStream, so the module would not be used anymore?

@dominictarr
Copy link
Owner

github.com/MetaMask said they would maintain it (since they use it and are high value target) they are added as npm owner, but need to fork JSONStream on github. probably you need to hassle them on twitter.

@danfinlay @kumavis

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants