Skip to content

Commit

Permalink
Update for Web IDL extended attribute changes
Browse files Browse the repository at this point in the history
[NoInterfaceObject] → [LegacyNoInterfaceObject]. This follows whatwg/webidl#870.

This also replaces a couple instances of [NoInterfaceObject] with the interface mixin concept, as was previously done in 2df151b and a6f9909.
  • Loading branch information
domenic committed Apr 8, 2020
1 parent e069440 commit 2d43702
Show file tree
Hide file tree
Showing 53 changed files with 69 additions and 75 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,9 @@

try {
var foo = ArrayBufferView;
testFailed('ArrayBufferView has [NoInterfaceObject] extended attribute and should not be defined');
testFailed('ArrayBufferView is a typedef and should not be defined');
} catch (e) {
testPassed('ArrayBufferView has [NoInterfaceObject] extended attribute and was (correctly) not defined');
testPassed('ArrayBufferView is a typedef and was (correctly) not defined');
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,9 @@

try {
var foo = ArrayBufferView;
testFailed('ArrayBufferView has [NoInterfaceObject] extended attribute and should not be defined');
testFailed('ArrayBufferView is a typedef and should not be defined');
} catch (e) {
testPassed('ArrayBufferView has [NoInterfaceObject] extended attribute and was (correctly) not defined');
testPassed('ArrayBufferView is a typedef and was (correctly) not defined');
}

// Uint8ClampedArray inherited from Uint8Array in earlier versions
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,9 @@

try {
var foo = ArrayBufferView;
testFailed('ArrayBufferView has [NoInterfaceObject] extended attribute and should not be defined');
testFailed('ArrayBufferView is a typedef and should not be defined');
} catch (e) {
testPassed('ArrayBufferView has [NoInterfaceObject] extended attribute and was (correctly) not defined');
testPassed('ArrayBufferView is a typedef and was (correctly) not defined');
}

// Uint8ClampedArray inherited from Uint8Array in earlier versions
Expand Down
2 changes: 1 addition & 1 deletion extensions/ANGLE_instanced_arrays/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
</p>
</overview>
<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface ANGLE_instanced_arrays {
const GLenum VERTEX_ATTRIB_ARRAY_DIVISOR_ANGLE = 0x88FE;
void drawArraysInstancedANGLE(GLenum mode, GLint first, GLsizei count, GLsizei primcount);
Expand Down
2 changes: 1 addition & 1 deletion extensions/EXT_blend_minmax/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
</overview>

<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface EXT_blend_minmax {
const GLenum MIN_EXT = 0x8007;
const GLenum MAX_EXT = 0x8008;
Expand Down
2 changes: 1 addition & 1 deletion extensions/EXT_clip_cull_distance/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
</overview>

<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface EXT_clip_cull_distance {
const GLenum MAX_CLIP_DISTANCES_EXT = 0x0D32;
const GLenum MAX_CULL_DISTANCES_EXT = 0x82F9;
Expand Down
2 changes: 1 addition & 1 deletion extensions/EXT_color_buffer_float/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
</overview>

<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface EXT_color_buffer_float {
}; // interface EXT_color_buffer_float
</idl>
Expand Down
2 changes: 1 addition & 1 deletion extensions/EXT_color_buffer_half_float/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
</overview>

<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface EXT_color_buffer_half_float {
const GLenum RGBA16F_EXT = 0x881A;
const GLenum RGB16F_EXT = 0x881B;
Expand Down
4 changes: 2 additions & 2 deletions extensions/EXT_disjoint_timer_query/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@
<idl xml:space="preserve">
typedef unsigned long long GLuint64EXT;

[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface WebGLTimerQueryEXT : WebGLObject {
};

[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface EXT_disjoint_timer_query {
const GLenum QUERY_COUNTER_BITS_EXT = 0x8864;
const GLenum CURRENT_QUERY_EXT = 0x8865;
Expand Down
2 changes: 1 addition & 1 deletion extensions/EXT_disjoint_timer_query_webgl2/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
<idl xml:space="preserve">
typedef unsigned long long GLuint64EXT;

[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface EXT_disjoint_timer_query_webgl2 {
const GLenum QUERY_COUNTER_BITS_EXT = 0x8864;
const GLenum TIME_ELAPSED_EXT = 0x88BF;
Expand Down
2 changes: 1 addition & 1 deletion extensions/EXT_float_blend/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
</overview>

<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface EXT_float_blend {
}; // interface EXT_float_blend
</idl>
Expand Down
2 changes: 1 addition & 1 deletion extensions/EXT_frag_depth/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
</overview>

<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface EXT_frag_depth {
};
</idl>
Expand Down
2 changes: 1 addition & 1 deletion extensions/EXT_sRGB/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
</overview>

<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface EXT_sRGB {
const GLenum SRGB_EXT = 0x8C40;
const GLenum SRGB_ALPHA_EXT = 0x8C42;
Expand Down
2 changes: 1 addition & 1 deletion extensions/EXT_shader_texture_lod/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
</overview>

<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface EXT_shader_texture_lod {
};
</idl>
Expand Down
2 changes: 1 addition & 1 deletion extensions/EXT_texture_filter_anisotropic/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
</features>
</overview>
<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface EXT_texture_filter_anisotropic {
const GLenum TEXTURE_MAX_ANISOTROPY_EXT = 0x84FE;
const GLenum MAX_TEXTURE_MAX_ANISOTROPY_EXT = 0x84FF;
Expand Down
2 changes: 1 addition & 1 deletion extensions/OES_element_index_uint/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
</features>
</overview>
<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface OES_element_index_uint {
};
</idl>
Expand Down
2 changes: 1 addition & 1 deletion extensions/OES_fbo_render_mipmap/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
</overview>

<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface OES_fbo_render_mipmap {
};
</idl>
Expand Down
2 changes: 1 addition & 1 deletion extensions/OES_standard_derivatives/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
</features>
</overview>
<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface OES_standard_derivatives {
const GLenum FRAGMENT_SHADER_DERIVATIVE_HINT_OES = 0x8B8B;
};
Expand Down
2 changes: 1 addition & 1 deletion extensions/OES_texture_float/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
</overview>

<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface OES_texture_float { }; </idl>

<history>
Expand Down
2 changes: 1 addition & 1 deletion extensions/OES_texture_float_linear/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
</overview>

<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface OES_texture_float_linear { };</idl>

<history>
Expand Down
2 changes: 1 addition & 1 deletion extensions/OES_texture_half_float/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
</overview>

<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface OES_texture_half_float {
const GLenum HALF_FLOAT_OES = 0x8D61;
};
Expand Down
2 changes: 1 addition & 1 deletion extensions/OES_texture_half_float_linear/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
</overview>

<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface OES_texture_half_float_linear { };</idl>

<history>
Expand Down
4 changes: 2 additions & 2 deletions extensions/OES_vertex_array_object/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@
<mirrors href="http://www.khronos.org/registry/gles/extensions/OES/OES_vertex_array_object.txt" name="OES_vertex_array_object" />
</overview>
<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface WebGLVertexArrayObjectOES : WebGLObject {
};

[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface OES_vertex_array_object {
const GLenum VERTEX_ARRAY_BINDING_OES = 0x85B5;

Expand Down
2 changes: 1 addition & 1 deletion extensions/WEBGL_color_buffer_float/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
</overview>

<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface WEBGL_color_buffer_float {
const GLenum RGBA32F_EXT = 0x8814;
const GLenum FRAMEBUFFER_ATTACHMENT_COMPONENT_TYPE_EXT = 0x8211;
Expand Down
2 changes: 1 addition & 1 deletion extensions/WEBGL_compressed_texture_astc/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@
</features>
</overview>
<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface WEBGL_compressed_texture_astc {
/* Compressed Texture Format */
const GLenum COMPRESSED_RGBA_ASTC_4x4_KHR = 0x93B0;
Expand Down
2 changes: 1 addition & 1 deletion extensions/WEBGL_compressed_texture_etc/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
</features>
</overview>
<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface WEBGL_compressed_texture_etc {
/* Compressed Texture Formats */
const GLenum COMPRESSED_R11_EAC = 0x9270;
Expand Down
2 changes: 1 addition & 1 deletion extensions/WEBGL_compressed_texture_etc1/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
</features>
</overview>
<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface WEBGL_compressed_texture_etc1 {
/* Compressed Texture Format */
const GLenum COMPRESSED_RGB_ETC1_WEBGL = 0x8D64;
Expand Down
2 changes: 1 addition & 1 deletion extensions/WEBGL_compressed_texture_pvrtc/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
</features>
</overview>
<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface WEBGL_compressed_texture_pvrtc {
/* Compressed Texture Formats */
const GLenum COMPRESSED_RGB_PVRTC_4BPPV1_IMG = 0x8C00;
Expand Down
2 changes: 1 addition & 1 deletion extensions/WEBGL_compressed_texture_s3tc/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
</features>
</overview>
<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface WEBGL_compressed_texture_s3tc {
/* Compressed Texture Formats */
const GLenum COMPRESSED_RGB_S3TC_DXT1_EXT = 0x83F0;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
</features>
</overview>
<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface WEBGL_compressed_texture_s3tc_srgb {
/* Compressed Texture Formats */
const GLenum COMPRESSED_SRGB_S3TC_DXT1_EXT = 0x8C4C;
Expand Down
2 changes: 1 addition & 1 deletion extensions/WEBGL_debug_renderer_info/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<p>WebGL implementations might mask the <code>RENDERER</code> and <code>VENDOR</code> strings of the underlying graphics driver for privacy reasons. This extension exposes new tokens to query this information in a guaranteed manner for debugging purposes.</p>
</overview>
<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface WEBGL_debug_renderer_info {

const GLenum UNMASKED_VENDOR_WEBGL = 0x9245;
Expand Down
2 changes: 1 addition & 1 deletion extensions/WEBGL_debug_shaders/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
</p>
</overview>
<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface WEBGL_debug_shaders {

DOMString getTranslatedShaderSource(WebGLShader shader);
Expand Down
2 changes: 1 addition & 1 deletion extensions/WEBGL_depth_texture/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@
</features>
</overview>
<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface WEBGL_depth_texture {
const GLenum UNSIGNED_INT_24_8_WEBGL = 0x84FA;
};
Expand Down
2 changes: 1 addition & 1 deletion extensions/WEBGL_draw_buffers/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
</features>
</overview>
<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface WEBGL_draw_buffers {
const GLenum COLOR_ATTACHMENT0_WEBGL = 0x8CE0;
const GLenum COLOR_ATTACHMENT1_WEBGL = 0x8CE1;
Expand Down
2 changes: 1 addition & 1 deletion extensions/WEBGL_lose_context/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
</p>
</overview>
<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface WEBGL_lose_context {
void loseContext();
void restoreContext();
Expand Down
2 changes: 1 addition & 1 deletion extensions/extension.xsl
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@
<xsl:template match="interface" mode="newfun">
<dt class="idl-code">
<xsl:if test="@noobject = 'true'">
<xsl:text>[NoInterfaceObject]</xsl:text><br/>
<xsl:text>[LegacyLegacyNoInterfaceObject]</xsl:text><br/>
</xsl:if>
<xsl:text>interface </xsl:text>
<em><xsl:value-of select="@name" /></em>
Expand Down
4 changes: 2 additions & 2 deletions extensions/proposals/WEBGL_debug/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
</overview>

<idl xml:space="preserve"><![CDATA[
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface WEBGL_debug : EventTarget {
const GLenum MAX_DEBUG_MESSAGE_LENGTH_KHR = 0x9143;
const GLenum MAX_DEBUG_GROUP_STACK_DEPTH_KHR = 0x826C;
Expand Down Expand Up @@ -155,7 +155,7 @@ interface WEBGL_debug : EventTarget {
DOMString getObjectLabelKHR(WebGLObject? object);
}; // interface WEBGL_debug
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface WebGLDebugMessage : Event {
readonly attribute GLenum source;
readonly attribute GLenum type;
Expand Down
6 changes: 3 additions & 3 deletions extensions/proposals/WEBGL_dynamic_texture/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@
</overview>

<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface WEBGL_dynamic_texture {
typedef double WDTNanoTime;

Expand Down Expand Up @@ -501,7 +501,7 @@ WDTNanoTime ustnow();</pre></li></p>
<p>The <code>WDTStreamFrameInfo</code> interface represents information
about a frame acquired from a WDTStream.</p>

<pre class="idl" xml:space="preserve">[NoInterfaceObject] interface WDTStreamFrameInfo {
<pre class="idl" xml:space="preserve">[LegacyNoInterfaceObject] interface WDTStreamFrameInfo {
readonly attribute double frameTime;
readonly attribute WDTNanoTime presentTime;
};</pre>
Expand Down Expand Up @@ -531,7 +531,7 @@ WDTNanoTime ustnow();</pre></li></p>
for controlling an image stream being fed to a dynamic texture
object.</p>

<pre class="idl" xml:space="preserve">[NoInterfaceObject] interface WDTStream {
<pre class="idl" xml:space="preserve">[LegacyNoInterfaceObject] interface WDTStream {
typedef (HTMLCanvasElement or
HTMLImageElement or
HTMLVideoElement) StreamSource;
Expand Down
2 changes: 1 addition & 1 deletion extensions/proposals/WEBGL_subarray_uploads/extension.xml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
</overview>

<idl xml:space="preserve">
[NoInterfaceObject]
[LegacyNoInterfaceObject]
interface WEBGL_subarray_uploads {
void bufferSubData(GLenum target, GLsizeiptr bufferOffset, GLsizeiptr subarrayOffset,
GLsizeiptr subarraySize, (ArrayBuffer or SharedArrayBuffer) data);
Expand Down
Loading

0 comments on commit 2d43702

Please sign in to comment.