-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect TTL #32
Respect TTL #32
Conversation
Cache When expiration is enabled, TTL is stored in the RR. The only use is in stringification to zone file format. If that's not worth storing it I can take it out. The current code is stringifying with a static TTL of 3600. I'm not familiar with the godoc system. Should I be doing anything to make those docs update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Only a few minor changes and this should be good to go.
Thanks a lot for this guys. Will go over all of it. |
Thanks! |
Thanks for the review and merge guys. |
Adds expiration support to the cache. Sets up RRs to expire based on TTL.
If the patch is accepted I intend to make a submission to
k6
usingdnsr
as the caching resolver, discussed in grafana/k6#726.The GooglePTR test seems to be timing out on my system but the expiration tests pass.
Closes #31.