Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse explain select and explain options #938

Merged
merged 6 commits into from
Nov 11, 2024
Merged

parse explain select and explain options #938

merged 6 commits into from
Nov 11, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Nov 11, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

Main PR
Total 42090 42090
Successful 14213 14213
Failures 27877 27877
Partial Successes1 4717 4717
Main PR
Successful 33.7681% 33.7681%
Failures 66.2319% 66.2319%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct. ↩

zachmu
zachmu approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice work

@jycor jycor enabled auto-merge (squash) November 11, 2024 23:30
@jycor jycor merged commit d54fd0c into main Nov 11, 2024
13 checks passed
@jycor jycor deleted the james/explain branch November 11, 2024 23:46
@BrewTestBot BrewTestBot mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jycor @zachmu