Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rule changes #872

Merged
merged 4 commits into from
Oct 21, 2024
Merged

rule changes #872

merged 4 commits into from
Oct 21, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Oct 21, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited
Loading

Main PR
Total 42090 42090
Successful 12807 12807
Failures 29283 29283
Partial Successes1 4893 4893
Main PR
Successful 30.4277% 30.4277%
Failures 69.5723% 69.5723%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct. ↩

@jycor jycor mentioned this pull request Oct 21, 2024
Merged
@jycor jycor reopened this Oct 21, 2024
@jycor jycor enabled auto-merge October 21, 2024 23:11
max-hoffman
max-hoffman approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one q

server/analyzer/init.go Show resolved Hide resolved
@jycor jycor merged commit 28bfd68 into main Oct 21, 2024
13 checks passed
@jycor jycor deleted the james/rules branch October 21, 2024 23:22
@BrewTestBot BrewTestBot mentioned this pull request Oct 24, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Nov 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jycor @max-hoffman