Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foreign key tests #862

Merged
merged 19 commits into from
Oct 17, 2024
Merged

Foreign key tests #862

merged 19 commits into from
Oct 17, 2024

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Oct 16, 2024

Depends on dolthub/dolt#8461

Hydrocharged
Hydrocharged approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a bats test or two as well, just to be completely sure that serialization is working correctly between server starts

@github-actions GitHub Actions
Copy link
Contributor

Main PR
Total 42090 42090
Successful 12743 12743
Failures 29347 29347
Partial Successes1 4897 4897
Main PR
Successful 30.2756% 30.2756%
Failures 69.7244% 69.7244%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct. ↩

@zachmu
Copy link
Member Author

zachmu commented Oct 17, 2024

Maybe add a bats test or two as well, just to be completely sure that serialization is working correctly between server starts

Done

@zachmu zachmu enabled auto-merge October 17, 2024 19:12
@zachmu zachmu merged commit 513d58e into main Oct 17, 2024
13 checks passed
@zachmu zachmu deleted the zachmu/foreign-keys branch October 17, 2024 20:50
@BrewTestBot BrewTestBot mentioned this pull request Nov 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachmu @Hydrocharged