Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip tests for dolt_revert #820

Merged
merged 21 commits into from
Oct 8, 2024
Merged

Unskip tests for dolt_revert #820

merged 21 commits into from
Oct 8, 2024

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Oct 8, 2024 •
edited
Loading

Stacked on #818

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024 •
edited
Loading

Main PR
Total 42090 42090
Successful 12700 12700
Failures 29390 29390
Partial Successes1 4894 4894
Main PR
Successful 30.1734% 30.1734%
Failures 69.8266% 69.8266%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct. ↩

@Hydrocharged Hydrocharged changed the base branch from main to zachmu/as-of October 8, 2024 08:44
Hydrocharged
Hydrocharged approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hydrocharged
Copy link
Collaborator

I changed your base to point to the other PR to make it easier to see the changes here

@zachmu zachmu changed the base branch from zachmu/as-of to main October 8, 2024 18:31
@zachmu zachmu enabled auto-merge October 8, 2024 19:30
@zachmu zachmu merged commit bb1ad6f into main Oct 8, 2024
13 checks passed
@zachmu zachmu deleted the zachmu/dolt-revert branch October 8, 2024 19:34
@BrewTestBot BrewTestBot mentioned this pull request Nov 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachmu @Hydrocharged