Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff tests for changes in multiple schemas #788

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Diff tests for changes in multiple schemas #788

merged 2 commits into from
Oct 2, 2024

Conversation

tbantle22
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024 •
edited
Loading

Main PR
Total 42090 42090
Successful 12375 12375
Failures 29715 29715
Partial Successes1 4915 4915
Main PR
Successful 29.4013% 29.4013%
Failures 70.5987% 70.5987%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct. ↩

@tbantle22 tbantle22 marked this pull request as ready for review October 2, 2024 19:17
@tbantle22 tbantle22 requested a review from zachmu October 2, 2024 19:26
zachmu
zachmu approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

testing/postgres-client-tests/node/workbenchTests/diffs.js Show resolved Hide resolved
testing/postgres-client-tests/node/workbenchTests/diffs.js Show resolved Hide resolved
Base automatically changed from taylor/diff-tests to main October 2, 2024 19:54
@tbantle22 tbantle22 merged commit dbf4ed5 into main Oct 2, 2024
13 checks passed
@tbantle22 tbantle22 deleted the taylor/diff-schema branch October 2, 2024 23:14
@BrewTestBot BrewTestBot mentioned this pull request Nov 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbantle22 @zachmu