Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smoke tests for dolt diff functions/tables #747

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Smoke tests for dolt diff functions/tables #747

merged 2 commits into from
Sep 24, 2024

Conversation

tbantle22
Copy link
Contributor

@github-actions GitHub Actions
Copy link
Contributor

Main PR
Total 42090 42090
Successful 11832 11832
Failures 30258 30258
Partial Successes1 4792 4792
Main PR
Successful 28.1112% 28.1112%
Failures 71.8888% 71.8888%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct. ↩

zachmu
zachmu approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from taylor/work-tests-2 to main September 24, 2024 21:54
@tbantle22 tbantle22 merged commit 7089655 into main Sep 24, 2024
13 checks passed
@tbantle22 tbantle22 deleted the taylor/diff-tests branch September 24, 2024 22:48
@BrewTestBot BrewTestBot mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbantle22 @zachmu