Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ParameterObjectIDs in Parse message for binding variable types #681

Merged
merged 2 commits into from
Sep 6, 2024
Merged

use ParameterObjectIDs in Parse message for binding variable types #681

merged 2 commits into from
Sep 6, 2024

Conversation

jennifersp
Copy link
Contributor

Note: the prepared tests don't utilize this field in the Parse message, so it needs to extract the binding value types from analyzed plan of the query.

Hydrocharged
Hydrocharged approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jennifersp jennifersp merged commit 7663b93 into main Sep 6, 2024
9 checks passed
@jennifersp jennifersp deleted the jennifer/parse-parameter branch September 6, 2024 17:35
@BrewTestBot BrewTestBot mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennifersp @Hydrocharged