Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented DISCARD #596

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Implemented DISCARD #596

merged 4 commits into from
Aug 12, 2024

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Aug 9, 2024 •
edited
Loading

Fixes #591

@zachmu zachmu mentioned this pull request Aug 9, 2024
Closed
Hydrocharged
Hydrocharged approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

server/ast/discard.go Outdated Show resolved Hide resolved
@zachmu zachmu enabled auto-merge August 12, 2024 18:32
@zachmu zachmu merged commit 8d9ec55 into main Aug 12, 2024
9 checks passed
@zachmu zachmu deleted the zachmu/discard branch August 12, 2024 18:38
@BrewTestBot BrewTestBot mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support DISCARD statements
2 participants
@zachmu @Hydrocharged