Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support INTERVAL type and AGE() function #585

Merged
merged 12 commits into from
Aug 10, 2024
Merged

support INTERVAL type and AGE() function #585

merged 12 commits into from
Aug 10, 2024

Conversation

jennifersp
Copy link
Contributor

No description provided.

Hydrocharged
Hydrocharged reviewed Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! We need to add the casts and comparison operators for interval though, along with tests for those as well. I'll review those as well once they're in.

server/types/interval_array.go Outdated Show resolved Hide resolved
server/types/interval.go Show resolved Hide resolved
Base automatically changed from jennifer/more-functions to main August 8, 2024 17:57
@zachmu zachmu mentioned this pull request Aug 8, 2024
Closed
Hydrocharged
Hydrocharged reviewed Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change the casts and serialization, but besides that everything still looks pretty good! Wanna make sure the serialization looks good before we merge the final commit.

server/cast/interval.go Outdated Show resolved Hide resolved
server/cast/time.go Outdated Show resolved Hide resolved
server/functions/binary/plus.go Outdated Show resolved Hide resolved
server/types/date.go Show resolved Hide resolved
server/types/interval.go Outdated Show resolved Hide resolved
testing/go/functions_test.go Outdated Show resolved Hide resolved
testing/go/types_test.go Outdated Show resolved Hide resolved
testing/go/types_test.go Show resolved Hide resolved
zachmu
zachmu approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked out the serialization stuff, Daylon, should give a final sign off.

server/types/interval.go Outdated Show resolved Hide resolved
server/types/interval.go Show resolved Hide resolved
@zachmu zachmu mentioned this pull request Aug 9, 2024
Closed
Hydrocharged
Hydrocharged approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

server/types/interval.go Outdated Show resolved Hide resolved
@jennifersp jennifersp enabled auto-merge (squash) August 10, 2024 22:36
@jennifersp jennifersp merged commit fb68084 into main Aug 10, 2024
9 checks passed
@jennifersp jennifersp deleted the jennifer/interval-type branch August 10, 2024 22:45
@BrewTestBot BrewTestBot mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jennifersp @zachmu @Hydrocharged