Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more pg functions and extract() function #584

Merged
merged 6 commits into from
Aug 8, 2024
Merged

add more pg functions and extract() function #584

merged 6 commits into from
Aug 8, 2024

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented Aug 7, 2024 •
edited
Loading

Added temporary resolution for handling ENUM type as TEXT type until we support CREATE TYPE statement.
Added functions:

  • extract - partially works
  • pg_get_function_identity_arguments - parses
  • pg_get_partkeydef - parses
  • pg_postmaster_start_time - parses

Hydrocharged
Hydrocharged approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just need to fix the merge remnants in the test file.

server/ast/expr.go Outdated Show resolved Hide resolved
server/functions/extract.go Outdated Show resolved Hide resolved
postgres/messages/row_description.go Show resolved Hide resolved
@jennifersp jennifersp merged commit aaadf3f into main Aug 8, 2024
9 checks passed
@jennifersp jennifersp deleted the jennifer/more-functions branch August 8, 2024 17:57
@BrewTestBot BrewTestBot mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennifersp @Hydrocharged