Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ANY/SOME expression #520

Merged
merged 8 commits into from
Aug 1, 2024
Merged

Implement ANY/SOME expression #520

merged 8 commits into from
Aug 1, 2024

Conversation

tbantle22
Copy link
Contributor

No description provided.

@tbantle22 tbantle22 force-pushed the taylor/any branch 3 times, most recently from 7b62ce8 to 8e7c9ae Compare July 26, 2024 22:51
@tbantle22 tbantle22 changed the title Start on ANY expression Implement ANY expression Jul 26, 2024
@tbantle22 tbantle22 changed the title Implement ANY expression Implement ANY/SOME expression Jul 29, 2024
@tbantle22 tbantle22 marked this pull request as ready for review July 29, 2024 18:21
Hydrocharged
Hydrocharged approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just some performance feedback. It's not truly necessary to get the PR out, but it's worth knocking out if you can.

server/expression/any.go Outdated Show resolved Hide resolved
server/expression/any.go Outdated Show resolved Hide resolved
server/expression/any.go Outdated Show resolved Hide resolved
server/expression/any.go Outdated Show resolved Hide resolved
server/expression/any.go Outdated Show resolved Hide resolved
Hydrocharged
Hydrocharged approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

testing/go/expressions_test.go Outdated Show resolved Hide resolved
server/expression/any.go Outdated Show resolved Hide resolved
server/expression/any.go Outdated Show resolved Hide resolved
server/expression/any.go Outdated Show resolved Hide resolved
@tbantle22 tbantle22 merged commit fb47d56 into main Aug 1, 2024
9 checks passed
@tbantle22 tbantle22 deleted the taylor/any branch August 1, 2024 17:04
@BrewTestBot BrewTestBot mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbantle22 @Hydrocharged