Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix column name for functions #495

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Fix column name for functions #495

merged 4 commits into from
Jul 16, 2024

Conversation

tbantle22
Copy link
Contributor

@tbantle22 tbantle22 commented Jul 15, 2024

Fixes #486

@tbantle22 tbantle22 changed the title Fix function column name Fix column name for functions Jul 15, 2024
@tbantle22 tbantle22 marked this pull request as ready for review July 15, 2024 23:21
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few comments

testing/go/framework.go Show resolved Hide resolved
testing/go/framework.go Outdated Show resolved Hide resolved
postgres/parser/sem/tree/expr.go Show resolved Hide resolved
testing/go/functions_test.go Outdated Show resolved Hide resolved
testing/go/functions_test.go Outdated Show resolved Hide resolved
@tbantle22 tbantle22 merged commit feeac0e into main Jul 16, 2024
9 checks passed
@tbantle22 tbantle22 deleted the taylor/func-fix branch July 16, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SELECT function() returned column name is incorrect
2 participants