Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use table_schema from information_schema.tables for schema name #426

Merged
merged 10 commits into from
Jun 26, 2024
Merged

use table_schema from information_schema.tables for schema name #426

merged 10 commits into from
Jun 26, 2024

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented Jun 24, 2024 •
edited
Loading

of \d and \dt commands. This allows these commands not to display pg_catalog tables

Depends on dolthub/go-mysql-server#2569 and dolthub/dolt#8062

@jennifersp jennifersp requested a review from zachmu June 24, 2024 21:44
zachmu
zachmu reviewed Jun 25, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but you should add some engine tests for information_schema.table queries as well.

zachmu
zachmu approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

testing/go/information_schema_test.go Outdated Show resolved Hide resolved
zachmu
zachmu approved these changes Jun 25, 2024
View reviewed changes
testing/go/information_schema_test.go Outdated Show resolved Hide resolved
@jennifersp jennifersp enabled auto-merge (squash) June 25, 2024 23:41
@jennifersp jennifersp disabled auto-merge June 25, 2024 23:43
@jennifersp jennifersp enabled auto-merge (squash) June 25, 2024 23:46
@jennifersp jennifersp merged commit b972edb into main Jun 26, 2024
9 checks passed
@jennifersp jennifersp deleted the jennifer/psql-table-cmds branch June 26, 2024 00:01
@BrewTestBot BrewTestBot mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennifersp @zachmu