Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXECUTE doesn't send RowDescription #273

Merged
merged 1 commit into from
May 16, 2024
Merged

EXECUTE doesn't send RowDescription #273

merged 1 commit into from
May 16, 2024

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented May 15, 2024 •
edited
Loading

This PR fixes issue connecting to doltgres server using Postgres JDBC driver.

In Postgres docs, it says, "Execute doesn't cause ReadyForQuery or RowDescription to be issued."

Also, queries that don't return set of rows send NoData in response to Describe message.

@jennifersp jennifersp mentioned this pull request May 16, 2024
Closed
zachmu
zachmu approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixes the problem for me locally

server/connection_handler.go Show resolved Hide resolved
Hydrocharged
Hydrocharged approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jennifersp jennifersp merged commit 61c2de3 into main May 16, 2024
11 checks passed
@jennifersp jennifersp deleted the jennifer/row-desc branch May 16, 2024 18:07
@BrewTestBot BrewTestBot mentioned this pull request May 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jennifersp @zachmu @Hydrocharged