-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support CREATE VIEW
#168
support CREATE VIEW
#168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Only thing we need to add are tests that make use of some Postgres-specific syntax. One example is CREATE VIEW v AS SELECT pk::INT2 FROM t1 ORDER BY pk;
. Just a few different ones, as it looks like all of the defined views are fully valid MySQL statements, so we need to guarantee that it succeeds for invalid MySQL statements that are valid PostgreSQL statements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! Just have a big question regarding the usage of the vitess
parser instead of our Postgres parser.
Depends on:
add SubStatementStr for DDL struct vitess#332
use SubStatementStr field in DDL for getting sub statement in CREATE VIEW go-mysql-server#2448
add parser interface in engine go-mysql-server#2486
use parser interface in engine dolt#7819