Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New test runner #132

Merged
merged 2 commits into from
Feb 19, 2024
Merged

New test runner #132

merged 2 commits into from
Feb 19, 2024

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Feb 19, 2024

Test runner for docker-based replication tests

@zachmu
Copy link
Member Author

zachmu commented Feb 19, 2024

The approach I took is slightly different from examples in Dolt, which require copying files into the root where the Dockerfile lives. This approach is simpler (no accompanying action, no copying), and lets the tests be debugged locally with the same command run by the workflow runner.

Copy link
Contributor

@coffeegoddd coffeegoddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachmu zachmu merged commit 295577c into main Feb 19, 2024
8 checks passed
@zachmu zachmu deleted the zachmu/replication-docker-test branch February 19, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants