Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GetSchema for detached head #8434

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Fix GetSchema for detached head #8434

merged 1 commit into from
Oct 10, 2024

Conversation

tbantle22
Copy link
Contributor

No description provided.

@tbantle22 tbantle22 requested a review from zachmu October 9, 2024 23:44
@tbantle22 tbantle22 mentioned this pull request Oct 9, 2024
Merged
@coffeegoddd
Copy link
Contributor

@tbantle22 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
63c2a6f ok 5937457
version total_tests
63c2a6f 5937457
correctness_percentage
100.0

zachmu
zachmu approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbantle22 tbantle22 merged commit cec1feb into main Oct 10, 2024
34 of 35 checks passed
@tbantle22 tbantle22 deleted the taylor/detach-fix-2 branch October 10, 2024 17:21
@BrewTestBot BrewTestBot mentioned this pull request Oct 11, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Nov 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbantle22 @coffeegoddd @zachmu