-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
define schema for dolt_schemas table #8086
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the right approach.
The dolt_schemas table defines elements like views and triggers for tables in the database. It follows that we should have a dolt_schemas table in every database schema, to define the views etc. for that schema.
This is required to address e.g. dolthub/doltgresql#456
So this method needs to change: it need to specify a schema string (empty in the case of dolt).
Additional work is required for integration with DoltgreSQL. |
@jennifersp DOLT
|
…ound in session cache
Additional work is required for integration with DoltgreSQL. |
@jennifersp DOLT
|
Additional work is required for integration with DoltgreSQL. |
@jennifersp DOLT
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass, but the part highlighted in the comment doesn't seem quite right.
Additional work is required for integration with DoltgreSQL. |
@jennifersp DOLT
|
dolthub/doltgresql#454 depends on this PR.