Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define schema for dolt_schemas table #8086

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented Jun 28, 2024

dolthub/doltgresql#454 depends on this PR.

@jennifersp jennifersp requested a review from zachmu June 28, 2024 18:34
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right approach.

The dolt_schemas table defines elements like views and triggers for tables in the database. It follows that we should have a dolt_schemas table in every database schema, to define the views etc. for that schema.

This is required to address e.g. dolthub/doltgresql#456

So this method needs to change: it need to specify a schema string (empty in the case of dolt).

Copy link

Additional work is required for integration with DoltgreSQL.

@coffeegoddd
Copy link
Contributor

@jennifersp DOLT

comparing_percentages
100.000000 to 100.000000
version result total
0f6d6cc ok 5937457
version total_tests
0f6d6cc 5937457
correctness_percentage
100.0

Copy link

github-actions bot commented Jul 1, 2024

Additional work is required for integration with DoltgreSQL.

@coffeegoddd
Copy link
Contributor

@jennifersp DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e6f9398 ok 5937457
version total_tests
e6f9398 5937457
correctness_percentage
100.0

Copy link

github-actions bot commented Jul 1, 2024

Additional work is required for integration with DoltgreSQL.

@coffeegoddd
Copy link
Contributor

@jennifersp DOLT

comparing_percentages
100.000000 to 100.000000
version result total
be3893a ok 5937457
version total_tests
be3893a 5937457
correctness_percentage
100.0

Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, but the part highlighted in the comment doesn't seem quite right.

go/libraries/doltcore/sqle/schema_table.go Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jul 2, 2024

Additional work is required for integration with DoltgreSQL.

@coffeegoddd
Copy link
Contributor

@jennifersp DOLT

comparing_percentages
100.000000 to 100.000000
version result total
7a84e8c ok 5937457
version total_tests
7a84e8c 5937457
correctness_percentage
100.0

@jennifersp jennifersp merged commit bcf4dd5 into main Jul 2, 2024
21 checks passed
@jennifersp jennifersp deleted the jennifer/dolt_schemas branch July 2, 2024 15:57
nicktobey pushed a commit that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a view should add the view to the current schema instead of current database
4 participants