Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt/TAS: Improve TAS windows #8633

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Conversation

spycrab
Copy link
Contributor

@spycrab spycrab commented Feb 17, 2020

Before:
Before
Before
After:
After
After

@exurd
Copy link

exurd commented Feb 18, 2020

The circles in the GameCube window seem to have off-centre crosses.
I've aligned the circles before the change and after to see if the crosses got misaligned at some point, but there was no difference.
When aligned, the crosses match while the circles don't.
It's still using the crosses from before.

@spycrab
Copy link
Contributor Author

spycrab commented Feb 18, 2020

@exurd Yes, this PR does not intend to fix this bug. I might take a stab at doing that later. Is there already a bug report for this?

- Use the Dolphin Icon in TAS Windows
- Prevent deformation of the stick widget (dolphin-emu#11988)
- Improve visual appearance
- Set a reasonable minimum size
@spycrab
Copy link
Contributor Author

spycrab commented Feb 18, 2020

It might be fixed now not quite sure though.
Edit: Updated the screenshots

@spycrab spycrab merged commit 25d5f0d into dolphin-emu:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants