Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use valid IR calibration data #8292

Merged
merged 1 commit into from
Oct 6, 2019
Merged

Conversation

Pokechu22
Copy link
Contributor

Previously, IR calibration data with an invalid checksum was used, because the calibration produced a strange offset. I've replaced it with calibration data that encodes the same values as the data Nintendo falls back to when the checksum is bad.

I've also updated the documentation on wiibrew, though I'm not completely happy with the naming and I'm still not 100% sure what these values mean — but I know enough to at least replace it with the defaults.

It's worth noting that dolphin doesn't use the same value for acceleration as Nintendo defaults to — but it's probably not worth changing that as that would cause issues with TAS and such. Since IR already behaved as if it were the default, it's fine to change this one.

Previously, IR calibration data with an invalid checksum was used, because the calibration produced a strange offset.  I've replaced it with calibration data that encodes the same values as the data Nintendo falls back to when the checksum is bad.
@jordan-woyak
Copy link
Member

@dolphin-emu-bot rebuild.

Copy link
Member

@jordan-woyak jordan-woyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Untested.

@stenzek stenzek merged commit 9a68eaa into dolphin-emu:master Oct 6, 2019
Pokechu22 referenced this pull request Jul 24, 2020
Previously, only Mii data was written.  Additionally, the file containing mii data was shared for all Wiimotes, which made it a lot less useful.

Additionally, the file was read/written on each Wiimote read, even though the whole EEPROM was kept in memory.  This was bad for performance and not particularly necessary (it did enforce that the data was properly shared between all Wiimotes, but that's not something I want).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants