arm64: fixes around icache flushing #4204
Conversation
|
So THAT's what it is, thank you! Same issue in PPSSPP, we "solved" it with terrifying amounts of padding. |
| #endif | ||
| /* Don't rely on GCC's __clear_cache implementation, as it caches | ||
| * icache/dcache cache line sizes, that can vary between cores on | ||
| * big.LITTLE architectures. */ |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
lewurm
force-pushed
the
arm64-icache-big-little-fix
branch
from
e7acee0
to
8f4f8a4
Compare
|
@lewurm, have to fix these up as well: https://buildbot.dolphin-emu.org/builders/pr-android/builds/2688/steps/compile/logs/stdio |
lewurm
force-pushed
the
arm64-icache-big-little-fix
branch
from
8f4f8a4
to
0248ace
Compare
|
Thanks @skidau, fixed it up. |
|
One last thing, the lint fixes here: https://buildbot.dolphin-emu.org/builders/lint/builds/2695/steps/shell/logs/stdio |
lewurm
force-pushed
the
arm64-icache-big-little-fix
branch
from
0248ace
to
ce87586
Compare
|
fixed lint issues. Great CI setup btw! |
|
Tested this out and it works for me on a S7 Exynos. |
lewurm
force-pushed
the
arm64-icache-big-little-fix
branch
from
ce87586
to
fff8221
Compare
|
okay, one more try on the linter :) |
|
|
||
| addr = (u64)start & ~(u64)(dsize - 1); | ||
| for (; addr < (u64)end; addr += dsize) | ||
| __asm__ volatile("dc civac, %0" : : "r"(addr) : "memory"); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Not sure about processor != core, but this might still be a Exynos bug. Also no clue which one is better, CVAU or CIVAC. Both LGTM. |
|
Reviewed 1 of 1 files at r3. Comments from Reviewable |
|
Thanks for sharing the outcome :D |
…m of the mono project for the discovery and original fix. See dolphin-emu/dolphin#4204 and mono/mono#3549
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
The first hit on Google about "Exynos 8890 SIGILL" is a thread pointing out a dolphin crash on Samsung Galaxy S7. We had a similar issue in mono, see mono/mono#3549
Untested though: Anyone cares about testing it please?
This change is