DolphinQt: Fix TAS widgets not updating with enable controller input #11649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regressed in 0300b44. Specifically, the sliders and the stick/IR widgets did not update, but the spin boxes did update.
JosJuice
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regressed in 0300b44. Specifically, the sliders and the stick/IR widgets did not update, but the spin boxes did update.
This was based on @JosJuice's suggestion. It doesn't seem to cause any infinite loops of widgets updating the spin boxes updating widgets. For what it's worth #8268 had an infinite loop at some point which I solved using my own
ReentranceBlockerthat allows 2 levels of recursion, but there was more complication there with 4 sliders and a total weight value compared to just x and y values.