Expose TextEncoder for use in workers

[tootedom]

I noticed that when trying to use new TextEncoder() inside a worker, that it would resulting an a not defined error.

I've attempted to expose the text-encoding polyfil, in this pull request, which allows the use of TextEncoder within a worker.

[hankjacobs]

Thanks for this! With the holidays, things are a little more hectic than usual. I’ll try to review when I have a moment but it may take a little longer than normal.

[tootedom]

Hola,

No problem at all, totally understand about the holidays. It's the busy season.

cheers
/dom

[tootedom]

I've updated the pull, as a noticed TextDecoder.decode() from the text-encoding npm module wasn't working (not sure why).

As a result I took the polyfil for the decode from golang/go#27295 (it only supports utf-8, maybe it's worth removing text-encoding module and also using the TextEncoder from the same go lang polyfil? - one less external dependency)

[hankjacobs]

Thanks for the contribution! I'm not opposed to using Go's implementation for both TextEncoder and TextDecoder even if it only supports utf-8 (better than no support IMO). That being said, I do have some licensing concerns. I'll look into it and get back to you.

[tootedom]

Hi there,

I can now see why the TextDecoder from text-encoding isn't working (after some hacking locally) I'll see if I can work out a work around; as I see what you mean about the licensing from the go issue.

If my lack of is knowledge fails to get me a work around in the next couple of days I'll post here what I'm seeing.

Cheers
/dom

[tootedom]

Hola,

I've updated to monkey patch around the TextDecoder's decode method. The type checking at the beginning of the decode method was not recognising the internal buffer of the Uint8Array as an ArrayBuffer. The result being we ended up with bytes being a 0 array, and so TextDecoder.decode returned nothing.

The monkey patch, creates a new Uint8Array, with ArrayBuffer, setting contents from the original buffer. This results in TextDecoder's type checking working.

I'm not sure what the Root Cause of the missing type info is, maybe the vm runtime stuff. However, this does address it, and remove the need of that golang implementation.

Let me know your thoughts, cheers
/dom

[tootedom]

Hola,

I've pushed the changes mentioned, and merged in current master. Let me know your thoughts.

Cheers
/Dom

[hankjacobs]

Also, please resolve conflicts

[tootedom]

Let me know if that latest change matches what we were talking about.
cheers
/dom

[hankjacobs]

Looking great thus far. Some minor changes but we're in the home stretch. Thanks for all the hard work!

[tootedom]

updated.
cheers
/dom