daniel puzhenko #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolevoper
reviewed
Jan 8, 2025
| @@ -0,0 +1,60 @@ | |||
| const randomNumber = Math.floor(Math.random() * 20) + 1; | |||
| var guess; | |||
| if (guess > randomNumber) { | ||
| alert("Sorry, you guessed too high"); | ||
| } | ||
| else if (guess < randomNumber) { |
There was a problem hiding this comment.
could be just else - mutually exclusive
- Introduced a new TypeScript file for calculating the average of user-inputted numbers. - Removed outdated calculator HTML and TypeScript files to streamline the project.
…eration prompts, and remove old guessing game functionality
…or min and max operations, and add a .gitignore file to exclude specific settings
…d operations and displaying the student with the lowest grade
…lculation with alerts for invalid entries
…starting a new game, changing settings, and quitting; improve input handling for difficulty, number of guesses, and play mode
dolevoper
reviewed
Jan 12, 2025
| let numberCount = 0; | ||
| let userInput = Number(prompt("Enter a number")); | ||
|
|
||
| while (userInput !== null) { |
There was a problem hiding this comment.
Since the input is immediately cast to number, this condition would always be true and we get an infinite loop.
dolevoper
reviewed
Jan 12, 2025
| let userInput = Number(prompt("Enter a number")); | ||
|
|
||
| while (userInput !== null) { | ||
| let number = Number(userInput); |
There was a problem hiding this comment.
Could be const, this variable does not change value during runtime
|
Please don't use Hebrew characters nor spaces when naming files/folders |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.