Move type definitions to dev #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikra
reviewed
Jan 9, 2018
There was a problem hiding this comment.
Can you next time wait at least 24 hours for review? :D Reviews help to spots bugs and other stuff
Overall looks like it is working because now it installs only 116 packages vs 658 packages before 🎉
- package-json.lock is not updated yet
electron-rebuildshould be moved to dependencies since now I can't runnpm run electron-rebuild⚠️ - Maybe remove this comment
# You MAY need to run this if MagicMirror complains about Snowboysince you basically always have to run that on fresh install and it won't hurt anyways to run it. The comment just confuses people :P
|
Good idea about the 24 hours, ok sure I will fix this ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59