Skip to content

Commit

Permalink
address issue crytic#2127 and allow function parameter name to be emp…
Browse files Browse the repository at this point in the history
…ty when casting to string
  • Loading branch information
dokzai committed Oct 6, 2023
1 parent 1eaec64 commit 1cdb202
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 1 deletion.
1 change: 0 additions & 1 deletion slither/core/variables/variable.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,5 +179,4 @@ def solidity_signature(self) -> str:
return f'{name}({",".join(parameters)})'

def __str__(self) -> str:
assert self._name
return self._name
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
contract TestSlither {
function testFunction(uint256 param1, uint256, address param3) public {

}
}
15 changes: 15 additions & 0 deletions tests/e2e/compilation/test_resolution.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,18 @@ def test_cycle(solc_binary_path) -> None:
solc_path = solc_binary_path("0.8.0")
slither = Slither(Path(TEST_DATA_DIR, "test_cyclic_import", "a.sol").as_posix(), solc=solc_path)
_run_all_detectors(slither)


def test_contract_function_parameter(solc_binary_path) -> None:
solc_path = solc_binary_path("0.8.0")
standard_json = SolcStandardJson()
standard_json.add_source_file(
Path(TEST_DATA_DIR, "test_contract_data", "test_contract_data.sol").as_posix()
)
compilation = CryticCompile(standard_json, solc=solc_path)
slither = Slither(compilation)
contract = slither.contracts[0]

for function in contract.functions:
for parameter in function.parameters:
str(parameter)

0 comments on commit 1cdb202

Please sign in to comment.