improved compilation flags for fedora, improved fedora packaging for copr consumption #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. migrated to rpkg for ease of use 2. improved package to be more standard so it will build in COPR 3. added standard CXXFLAGS to improve compatibility with fedora (probably other distros too)
|
this is broken still, will fix in a bit sorry for the noise |
|
Thanks, your changes look good, i will merge them when you are ready. Meson support was added as a PR and i haven't had the time to learn enough about it and test it on all platforms to support it as a default. Therefore i would personally stick with make for now, but won't object if you choose meson. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Dokutan!
I am glad to see your project is doing well. Today I was working on some packaging stuff for Fedora and I created a github action to quickly package software into Fedora's COPR infrastructure (this is similar to Ubuntu's PPAs).
As I did this I wanted to try my creation on a small package and this project came to mind. I ran into some issues due to the way I packaged this earlier so I decided to rework it and make it more standard.
This is the result of those improvements. I hope it looks good.
Sidenote: I see you are migrating/migrated to meson - should I prefer to build that way?