Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Resourceful grid #1551

Closed
wants to merge 16 commits into from
Closed

[WIP] Resourceful grid #1551

wants to merge 16 commits into from

Conversation

tomdye
Copy link
Member

@tomdye tomdye commented Oct 8, 2020

Type: bug / feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit tests are included in the PR
  • For new widgets, an entry has been added to the .dojorc
  • For new widgets, theme.variant() is added to the root domnode
  • Any widget variant uses theme.compose like this
  • WidgetProperties are exported

Description:

Resolves #???

@vercel
Copy link

vercel bot commented Oct 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/bpbv9j8dk
✅ Preview: https://widget-test-docs-git-resourceful-grid.dojo1.vercel.app

[Deployment for 61d849b failed]

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojowidgets/8auhy6vqf
✅ Preview: https://dojowidgets-git-resourceful-grid.dojo1.vercel.app

[Deployment for 61d849b failed]

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #1551 (61d849b) into master (dc4caa0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1551   +/-   ##
=======================================
  Coverage   90.07%   90.07%           
=======================================
  Files          94       94           
  Lines        5047     5047           
  Branches     1375     1375           
=======================================
  Hits         4546     4546           
  Misses        249      249           
  Partials      252      252           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc4caa0...61d849b. Read the comment docs.

@agubler
Copy link
Member

agubler commented Apr 14, 2021

Closing until we are closer to being out of WIP

@agubler agubler closed this Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write new resources backed grid
2 participants