fixes #901 CompoundColumns with sort property causes an error #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that the target has contents or children before placing sort arrow UI. When trying to set the column sort arrow UI on a hidden column header we were making the assumption that the column header had children. But if the header was hidden it would cause an exception when trying to place the UI element.
|
This changeset has the unfortunate side-effect that the sort arrow pretty much never shows up anymore. I have an alternate fix on another branch: https://github.com/kfranqueiro/dgrid/commits/compoundcolumns-sort |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that the target has contents or children before placing sort
arrow UI.
When trying to set the column sort arrow UI on a hidden column header we
were making the assumption that the column header had children. But if
the header was hidden it would cause an exception when trying to place
the UI element.
fixes #901