Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DnD: Update dojo/dnd UI when an item is deselected programmatically #906

Merged
merged 1 commit into from
May 5, 2014
Merged

DnD: Update dojo/dnd UI when an item is deselected programmatically #906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ This document outlines changes since 0.3.0. For older changelogs, see the

* Fixed a regression in `ColumnHider` where the node to open the menu became
invisible on platforms with hidden scrollbars. (#886)
* Resolved an issue regarding `dojo/dnd` CSS classes and programmatic dgrid
deselection. (#906)
* `ColumnHider` now assigns its menu node an ID in the format
`{id}-hider-menu`, not `dgrid-hider-menu-{id}`.

Expand Down
3 changes: 3 additions & 0 deletions extensions/DnD.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,9 @@ define([
}
function deselectRow(row){
delete selectedNodes[row.id];
// Re-sync dojo/dnd UI classes based on deselection
// (unfortunately there is no good programmatic hook for this)
put(row.element, '!dojoDndItemSelected!dojoDndItemAnchor');
}

this.on("dgrid-select", function(event){
Expand Down