Updated editor tests to wait for edit() promise to resolve #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilures) because the test was not waiting for the promise from Editor#edit to resolve before deleting the grid.
… I fixed that. In doing so, I found two problems. 1) The tests active an editOn editor and then later try to move it. During the move (done via a DOM appendChild call), the blur event handler was firing and removing the editor from the DOM. That combo was causing an error in the browser. 2) The editor plug-in module defined variables in which it tracked active editor state. Because they were defined at the module level, that state was carrying over between tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the editor column plugin tests to wait for the promise returned by grid.edit() to resolve. Some of the tests were trying to test multiple columns so I divided them.