Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tree expand return a promise. #815

Closed
wants to merge 5 commits into from
Closed

Make tree expand return a promise. #815

wants to merge 5 commits into from

Conversation

edhager
Copy link
Contributor

@edhager edhager commented Jan 15, 2014

Fixes #739

edhager and others added 5 commits October 24, 2013 15:27
@edhager
Fix dojo#739: tree: make expand return a promise
4bca092
Improve tree expand promise tests to run fully
6b9199c
tree: Remove when call from query logic since we always have a promise
385b09f
tree: Add expand promise rejection test
1b15ac5
@edhager
Removed the call to _trackError in expand. The call is not necessary …
c182eaa 
…because the call to the query inside of renderQuery is wrapped by _trackError. The tree-expand-promise test now verifies the error event is being generated and I added additional tests for grids that do not have an implementation of renderQuery.
@kfranqueiro
Copy link
Member

Merged via dbcb6d0, 684b6f8, a812d9b, with further cleanup in cd42018.

@edhager edhager deleted the expand-promise branch February 24, 2014 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tree expand should return promise
2 participants
@edhager @kfranqueiro