Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Intern tests to Intern 4 #1473

Merged
merged 11 commits into from
Jun 9, 2020
Merged

Update Intern tests to Intern 4 #1473

merged 11 commits into from
Jun 9, 2020

Conversation

msssk
Copy link
Contributor

@msssk msssk commented Jun 2, 2020

Closes #1472

@msssk msssk requested a review from jason0x43 June 2, 2020 05:13
msssk
msssk commented Jun 2, 2020
View reviewed changes
test/intern/all.js Outdated Show resolved Hide resolved
@msssk msssk removed the request for review from jason0x43 June 2, 2020 05:19
@msssk msssk marked this pull request as ready for review June 6, 2020 05:01
@msssk
Copy link
Contributor Author

msssk commented Jun 6, 2020

@jason0x43 there's a lot of changes in this PR, and much of it repetitive. It would be much appreciated if you could review a few files:

  • intern.json
  • test/intern/README.md
  • test/intern/functional/util.js - still necessary and reasonable solution?
  • test/intern/functional/Keyboard.js - no need to look too closely here, unfortunately the diff does not make clear that most of the changes are simply indentation shifts

jason0x43
jason0x43 reviewed Jun 8, 2020
View reviewed changes
Copy link
Member

@jason0x43 jason0x43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding functional/util.js, that is still necessary (at least, Intern/Leadfoot doesn't check for those specific things).

Regarding the Keyboard.js diff whitespace, you can tell GitHub to ignore whitespace in a diff with a setting at the top of the diff. 😄

intern.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
test/intern/README.md Outdated Show resolved Hide resolved
test/intern/core/List.js Outdated Show resolved Hide resolved
test/intern/README.md Outdated Show resolved Hide resolved
msssk added 2 commits June 8, 2020 21:10
@msssk
Intern config: standardize on selenium tunnel, add timeout values
17c5db7 
Grunt: remove obsolete Intern tasks
README.md: replace testing info with link to test/README.md
test/intern/REAMDE.md: move to test/README.md and add info on non-Intern tests
test/index.html: improve layout
@msssk
tests: rename variable for Intern tdd interface from test to tdd
a546041
@msssk msssk merged commit a4783e8 into dojo:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason0x43 jason0x43 jason0x43 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Intern from 3 to 4
2 participants
@msssk @jason0x43