Fix DijitRegistry issues #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot a widget instance. Add destroyRecursive method becuase containers check for and call destroyRecursive in their destroyDecendants cleanup.
ghost
merged commit 
|
Good catch; thanks for pointing this out! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After using the DijitRegistry extension I noticed that it was not actually removing the widget from the registry. Also I was getting "Tried to register widget with id==..." errors if I loaded the same page twice and this was due to ContentPanes checking for and calling destroyRecursive on its child widgets. Destroy never actually was called.
Use widget id as argument for registry.remove as it takes an id and not a widget instance.
Add destroyRecursive method because containers check for and call destroyRecursive in their destroyDecendants cleanup.